Allow created date to be set by the user when exporting STEP and FBX#804
Closed
alteous wants to merge 2 commits intoKittyCAD:mainfrom
Closed
Allow created date to be set by the user when exporting STEP and FBX#804alteous wants to merge 2 commits intoKittyCAD:mainfrom
alteous wants to merge 2 commits intoKittyCAD:mainfrom
Conversation
Contributor
Author
|
I assumed the datetime would be serializable. I'll send it as https://www.rfc-editor.org/rfc/rfc3339 instead. |
Contributor
|
it is serializable, it will just work :) |
jessfraz
approved these changes
Mar 12, 2025
Contributor
|
add chrono feature flag to the serde lib |
Contributor
|
wait other way around add derive to chrono, idk you get what im saying its a flag somewhere |
Contributor
alteous
force-pushed
the
step-user-created-date
branch
from
bde22cf to
34d0357
Compare
alteous
changed the title
jessfraz
reviewed
Mar 12, 2025
|
|
||
| /// A wrapper for chrono types, since we need to impl Value for them. | ||
| #[derive(Clone, Copy, Debug, Eq, PartialEq, Hash, Default)] | ||
| #[derive(Clone, Copy, Debug, Eq, PartialEq, Hash, Default, Deserialize, Serialize, JsonSchema)] |
Contributor
There was a problem hiding this comment.
we need this equivalent here:
#[cfg_attr(feature = "ts-rs", derive(ts_rs::TS))]
#[cfg_attr(feature = "ts-rs", ts(export_to = "ModelingCmd.ts"))]
```
Contributor
There was a problem hiding this comment.
and i think the chrono flag on ts-rs
Contributor
There was a problem hiding this comment.
this is the flag https://docs.rs/crate/ts-rs/latest/features#chrono-impl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.